Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug or API issues? (altrank / galaxyscore script) - Reopened #159

Closed
dangalv opened this issue Nov 2, 2022 · 23 comments
Closed

Bug or API issues? (altrank / galaxyscore script) - Reopened #159

dangalv opened this issue Nov 2, 2022 · 23 comments
Assignees
Labels
bug Something isn't working

Comments

@dangalv
Copy link
Contributor

dangalv commented Nov 2, 2022

Hi guys, sorry to be annoying again. I'm on your side
But there is an error that I don't know if it's already an API error or a bug in the altrank and galaxyscore script encoding
I haven't used these scripts for a long time since I used botassistexplorer but for some reason this script got stuck and doesn't renew the coins in the altrank list (3c-tools error, not the script)
I did a clean install of the script installing helper requirements and the error persists.

image

04:45 ~/3commas-cyber-bots (main)$ ./galaxyscore.py
2022-11-02 04:45:44 - galaxyscore - INFO - 3C Cyber Bot-Helper galaxyscore
2022-11-02 04:45:44 - galaxyscore - INFO - Started on Wednesday 04:45:44 2022-11-02
2022-11-02 04:45:44 - galaxyscore - INFO - Notifications are disabled
2022-11-02 04:45:44 - galaxyscore - INFO - Created example config file '/home/droidg/3commas-cyber-bots/galaxyscore.ini', edit it and restart the program
04:45 ~/3commas-cyber-bots (main)$ ^C
04:46 ~/3commas-cyber-bots (main)$ ./galaxyscore.py
2022-11-02 05:47:11 - galaxyscore - INFO - 3C Cyber Bot-Helper galaxyscore
2022-11-02 05:47:11 - galaxyscore - INFO - Started on Wednesday 05:47:11 2022-11-02
2022-11-02 05:47:11 - galaxyscore - INFO - Notifications are disabled
2022-11-02 05:47:11 - galaxyscore - INFO - Loaded configuration from '/home/droidg/3commas-cyber-bots/galaxyscore.ini'
2022-11-02 05:47:11 - galaxyscore - INFO - Reloaded configuration from '/home/droidg/3commas-cyber-bots/galaxyscore.ini'
2022-11-02 05:47:11 - galaxyscore - INFO - Fetched 3Commas pairs blacklist OK (0 pairs)
2022-11-02 05:47:11 - galaxyscore - INFO - Fetched 3Commas price OK (20522.48)
Traceback (most recent call last):
File "/home/droidg/3commas-cyber-bots/./galaxyscore.py", line 372, in
usdtbtcprice = get_threecommas_btcusd(logger, api)
File "/home/droidg/3commas-cyber-bots/helpers/threecommas.py", line 74, in get_threecommas_btcusd
if isnan(price):
TypeError: must be real number, not str
04:47 ~/3commas-cyber-bots (main)$ ./altrank.py
2022-11-02 04:48:25 - altrank - INFO - 3C Cyber Bot-Helper altrank
2022-11-02 04:48:25 - altrank - INFO - Started on Wednesday 04:48:25 2022-11-02
2022-11-02 04:48:25 - altrank - INFO - Notifications are disabled
2022-11-02 04:48:25 - altrank - INFO - Created example config file '/home/droidg/3commas-cyber-bots/altrank.ini', edit it and restart the program
04:48 ~/3commas-cyber-bots (main)$ ./altrank.py
2022-11-02 05:50:35 - altrank - INFO - 3C Cyber Bot-Helper altrank
2022-11-02 05:50:35 - altrank - INFO - Started on Wednesday 05:50:35 2022-11-02
2022-11-02 05:50:35 - altrank - INFO - Notifications are disabled
2022-11-02 05:50:35 - altrank - INFO - Loaded configuration from '/home/droidg/3commas-cyber-bots/altrank.ini'
2022-11-02 05:50:35 - altrank - INFO - Reloaded configuration from '/home/droidg/3commas-cyber-bots/altrank.ini'
2022-11-02 05:50:35 - altrank - INFO - Fetched 3Commas pairs blacklist OK (0 pairs)
2022-11-02 05:50:35 - altrank - INFO - Fetched 3Commas price OK (20520.29)
Traceback (most recent call last):
File "/home/droidg/3commas-cyber-bots/./altrank.py", line 360, in
usdtbtcprice = get_threecommas_btcusd(logger, api)
File "/home/droidg/3commas-cyber-bots/helpers/threecommas.py", line 74, in get_threecommas_btcusd
if isnan(price):
TypeError: must be real number, not str
04:50 ~/3commas-cyber-bots (main)$

Thank you and sorry for my inconvenience. Cheers

@dangalv dangalv added the bug Something isn't working label Nov 2, 2022
@dangalv
Copy link
Contributor Author

dangalv commented Nov 2, 2022

Unfortunately the free lunarcrush api was revoked, so botassistexplorer (3c-tool) affected it as well. I guess there is no API error

@dangalv dangalv closed this as completed Nov 3, 2022
@dangalv dangalv reopened this Nov 3, 2022
@dangalv
Copy link
Contributor Author

dangalv commented Nov 3, 2022

Update: I bought the API for one day from lunarcrush and the script error is the same 😔

@dangalv dangalv changed the title Bug or API issues? (altrank / galaxyscore script) Bug or API issues? (altrank / galaxyscore script) - Reopened Nov 3, 2022
@thematikma
Copy link

thematikma commented Nov 5, 2022

Edit: The api v3 uses different endpoints and needs a auth header accept. I did take a look at the datasources.py, and my skills are way too noob for the implementation. 😅
The new docs are located here: https://lunarcrush.com/developers/api/endpoints

@amargedon
Copy link
Collaborator

Thanks, just replied to the other issue as well. Yes, these scripts need some work to match the new endpoint. Will look into this, not sure when however.

@dangalv
Copy link
Contributor Author

dangalv commented Nov 5, 2022

Thanks, just replied to the other issue as well. Yes, these scripts need some work to match the new endpoint. Will look into this, not sure when however.

Nice thanks!

@cyberjunky
Copy link
Owner

cyberjunky commented Nov 6, 2022

@dangalv @thematikma I have updated some code, using my new api3 key I got so far...
I'm still recovering from illness, maybe you can try and give some results...

2022-11-06 13:26:40 - altrank - ERROR - Fetching LunarCrush data failed 500 {"error":"Error: You must have at least $1 USD in your LunarCrush payments account to use this endpoint."}

@thematikma
Copy link

@cyberjunky @dangalv @amargedon Many thanks for your efforts! I will have a try later and post results.
And a speedy recovery to @cyberjunky

@cyberjunky
Copy link
Owner

It doesn't look to me API is free for any /coins calls (you need at least 240 credits per day 24 * 10 if you call every hour) which costs:
image

@dangalv
Copy link
Contributor Author

dangalv commented Nov 6, 2022

@dangalv @thematikma I have updated some code, using my new api3 key I got so far... I'm still recovering from illness, maybe you can try and give some results...

2022-11-06 13:26:40 - altrank - ERROR - Fetching LunarCrush data failed 500 {"error":"Error: You must have at least $1 USD in your LunarCrush payments account to use this endpoint."}

thank you mate! I hope you feel better, as soon as I can I will try the new config and let you know how it went

@dangalv
Copy link
Contributor Author

dangalv commented Nov 7, 2022

@cyberjunky

Well, I tell you about my experience with the galaxyscore script, which is the script one I need.
The coins are fetched but even if I put a high rank of 150 of the altrank coins and from 40 of galaxyscore, neither activates the bot.
Each API call spends an exuberant amount of credits about 10 credits, and I'm was naive thinking that I was going to have 2000 api calls.
But removing that detail, the script no longer has any error but does not place any coin on the bot

image

bot config:
image

log

2022-11-07 01:09:45 - galaxyscore_02 - INFO - 3C Cyber Bot-Helper galaxyscore_02
2022-11-07 01:09:45 - galaxyscore_02 - INFO - Started on Monday 01:09:45 2022-11-07
2022-11-07 01:09:45 - galaxyscore_02 - INFO - Notifications are disabled
2022-11-07 01:09:45 - galaxyscore_02 - INFO - Created example config file '/home/ubuntu/3commas-cyber-bots/galaxyscore_02.ini', edit it and restart the program
2022-11-07 03:39:17 - galaxyscore_02 - INFO - 3C Cyber Bot-Helper galaxyscore_02
2022-11-07 03:39:17 - galaxyscore_02 - INFO - Started on Monday 03:39:17 2022-11-07
2022-11-07 03:39:17 - galaxyscore_02 - INFO - Notifications are disabled
2022-11-07 03:39:17 - galaxyscore_02 - INFO - Loaded configuration from '/home/ubuntu/3commas-cyber-bots/galaxyscore_02.ini'
2022-11-07 03:39:17 - galaxyscore_02 - INFO - Reloaded configuration from '/home/ubuntu/3commas-cyber-bots/galaxyscore_02.ini'
2022-11-07 03:39:17 - galaxyscore_02 - INFO - Fetched 3Commas pairs blacklist OK (15 pairs)
2022-11-07 03:39:17 - galaxyscore_02 - INFO - Fetched 3Commas price OK (USDT_BTC 21002.37)
2022-11-07 03:39:17 - galaxyscore_02 - INFO - Fetched LunarCrush ranking OK (150 coins)
2022-11-07 03:39:18 - galaxyscore_02 - INFO - Bot base currency: USDT
2022-11-07 03:39:18 - galaxyscore_02 - INFO - Fetched 3Commas account market code in real mode OK (binance_futures)
2022-11-07 03:39:18 - galaxyscore_02 - INFO - Fetched 3Commas market data for 'binance_futures' OK (381 pairs)
2022-11-07 03:39:18 - galaxyscore_02 - INFO - Bot exchange: dangalv (binance_futures)
2022-11-07 03:39:18 - galaxyscore_02 - INFO - None of the 3c-tools bot-assist suggested pairs have been found on the dangalv (binance_futures) exchange!
2022-11-07 03:39:18 - galaxyscore_02 - INFO - Next update in 0:10:00 at 03:49:18
2022-11-07 03:49:18 - galaxyscore_02 - INFO - Reloaded configuration from '/home/ubuntu/3commas-cyber-bots/galaxyscore_02.ini'
2022-11-07 03:49:18 - galaxyscore_02 - INFO - Fetched 3Commas pairs blacklist OK (15 pairs)
2022-11-07 03:49:18 - galaxyscore_02 - INFO - Fetched 3Commas price OK (USDT_BTC 21002.0)
2022-11-07 03:49:19 - galaxyscore_02 - INFO - Fetched LunarCrush ranking OK (150 coins)
2022-11-07 03:49:19 - galaxyscore_02 - INFO - Bot base currency: USDT
2022-11-07 03:49:19 - galaxyscore_02 - INFO - Fetched 3Commas account market code in real mode OK (binance_futures)
2022-11-07 03:49:19 - galaxyscore_02 - INFO - Fetched 3Commas market data for 'binance_futures' OK (381 pairs)
2022-11-07 03:49:19 - galaxyscore_02 - INFO - Bot exchange: dangalv (binance_futures)
2022-11-07 03:49:19 - galaxyscore_02 - INFO - None of the 3c-tools bot-assist suggested pairs have been found on the dangalv (binance_futures) exchange!
2022-11-07 03:49:19 - galaxyscore_02 - INFO - Next update in 0:10:00 at 03:59:19
2022-11-07 03:50:39 - galaxyscore_02 - INFO - 3C Cyber Bot-Helper galaxyscore_02
2022-11-07 03:50:39 - galaxyscore_02 - INFO - Started on Monday 03:50:39 2022-11-07
2022-11-07 03:50:39 - galaxyscore_02 - INFO - Notifications are disabled
2022-11-07 03:50:39 - galaxyscore_02 - INFO - Loaded configuration from '/home/ubuntu/3commas-cyber-bots/galaxyscore_02.ini'
2022-11-07 03:50:39 - galaxyscore_02 - INFO - Reloaded configuration from '/home/ubuntu/3commas-cyber-bots/galaxyscore_02.ini'
2022-11-07 03:50:39 - galaxyscore_02 - INFO - Fetched 3Commas pairs blacklist OK (15 pairs)
2022-11-07 03:50:39 - galaxyscore_02 - INFO - Fetched 3Commas price OK (USDT_BTC 20968.32)
2022-11-07 03:50:40 - galaxyscore_02 - INFO - Fetched LunarCrush ranking OK (150 coins)
2022-11-07 03:50:40 - galaxyscore_02 - INFO - Bot base currency: USDT
2022-11-07 03:50:40 - galaxyscore_02 - INFO - Fetched 3Commas account market code in real mode OK (binance_futures)
2022-11-07 03:50:40 - galaxyscore_02 - INFO - Fetched 3Commas market data for 'binance_futures' OK (381 pairs)
2022-11-07 03:50:40 - galaxyscore_02 - INFO - Bot exchange: dangalv (binance_futures)
2022-11-07 03:50:40 - galaxyscore_02 - INFO - None of the 3c-tools bot-assist suggested pairs have been found on the dangalv (binance_futures) exchange!
2022-11-07 03:50:40 - galaxyscore_02 - INFO - Next update in 0:10:00 at 04:00:40
2022-11-07 03:52:16 - galaxyscore_02 - INFO - 3C Cyber Bot-Helper galaxyscore_02
2022-11-07 03:52:16 - galaxyscore_02 - INFO - Started on Monday 03:52:16 2022-11-07
2022-11-07 03:52:16 - galaxyscore_02 - INFO - Notifications are disabled
2022-11-07 03:52:16 - galaxyscore_02 - INFO - Loaded configuration from '/home/ubuntu/3commas-cyber-bots/galaxyscore_02.ini'
2022-11-07 03:52:16 - galaxyscore_02 - INFO - Reloaded configuration from '/home/ubuntu/3commas-cyber-bots/galaxyscore_02.ini'
2022-11-07 03:52:16 - galaxyscore_02 - INFO - Fetched 3Commas pairs blacklist OK (15 pairs)
2022-11-07 03:52:16 - galaxyscore_02 - INFO - Fetched 3Commas price OK (USDT_BTC 20962.48)
2022-11-07 03:52:17 - galaxyscore_02 - INFO - Fetched LunarCrush ranking OK (100 coins)
2022-11-07 03:52:17 - galaxyscore_02 - INFO - Bot base currency: USDT
2022-11-07 03:52:17 - galaxyscore_02 - INFO - Fetched 3Commas account market code in real mode OK (binance_futures)
2022-11-07 03:52:17 - galaxyscore_02 - INFO - Fetched 3Commas market data for 'binance_futures' OK (381 pairs)
2022-11-07 03:52:17 - galaxyscore_02 - INFO - Bot exchange: dangalv (binance_futures)
2022-11-07 03:52:17 - galaxyscore_02 - INFO - None of the 3c-tools bot-assist suggested pairs have been found on the dangalv (binance_futures) exchange!
2022-11-07 03:52:17 - galaxyscore_02 - INFO - Next update in 0:10:00 at 04:02:17
2022-11-07 05:53:04 - galaxyscore_02 - INFO - 3C Cyber Bot-Helper galaxyscore_02
2022-11-07 05:53:04 - galaxyscore_02 - INFO - Started on Monday 05:53:04 2022-11-07
2022-11-07 05:53:04 - galaxyscore_02 - INFO - Notifications are disabled
2022-11-07 05:53:04 - galaxyscore_02 - INFO - Loaded configuration from '/home/ubuntu/3commas-cyber-bots/galaxyscore_02.ini'
2022-11-07 05:53:04 - galaxyscore_02 - INFO - Reloaded configuration from '/home/ubuntu/3commas-cyber-bots/galaxyscore_02.ini'
2022-11-07 05:53:05 - galaxyscore_02 - INFO - Fetched 3Commas pairs blacklist OK (15 pairs)
2022-11-07 05:53:05 - galaxyscore_02 - INFO - Fetched 3Commas price OK (USDT_BTC 20887.97)
2022-11-07 05:53:06 - galaxyscore_02 - INFO - Fetched LunarCrush ranking OK (1000 coins)
2022-11-07 05:53:06 - galaxyscore_02 - INFO - Bot base currency: USDT
2022-11-07 05:53:06 - galaxyscore_02 - INFO - Fetched 3Commas account market code in real mode OK (binance_futures)
2022-11-07 05:53:06 - galaxyscore_02 - INFO - Fetched 3Commas market data for 'binance_futures' OK (381 pairs)
2022-11-07 05:53:06 - galaxyscore_02 - INFO - Bot exchange: dangalv (binance_futures)
2022-11-07 05:53:06 - galaxyscore_02 - INFO - None of the 3c-tools bot-assist suggested pairs have been found on the dangalv (binance_futures) exchange!
2022-11-07 05:53:06 - galaxyscore_02 - INFO - Next update in 0:10:00 at 06:03:06

@thematikma
Copy link

I agree with that. I would wish for a more attractive plan for private users. ~ $350 a year for hourly calls is nuts imho. I guess one could stop the scripts, when the market is low and safe some usd.

@Gh61
Copy link

Gh61 commented Nov 7, 2022

I'm honestly thinking about writing some grabber from webui in the future. If it would be possible, you would only need to have Lv. 4. which is one-time payment I suppose.

@cyberjunky
Copy link
Owner

@dangalv the 10 credits was what I expected it would cost for each call (after looking at the pricing), if you could buy 20K credits and call once every hour it would not be so bad... but the 1$ per day annoys me
That it would gonna cost a lot of money was expected for months... and I think altrank/galaxyscore is not that good anymore anyway...
If you still want me to debug the issue with the ranks please include the debug output.

@Gh61 if the developer api doc tool returns live data we just can scrape that ;-) no levels needed, but I can't check.

@spggooss
Copy link
Contributor

spggooss commented Nov 7, 2022

I'm honestly thinking about writing some grabber from webui in the future. If it would be possible, you would only need to have

It is possible already for free with the developer documentation (https://lunarcrush.com/developers/api/coins) . It provides a sample request, but it return the true data. So you dont need to have any Level access to get the data. However, the website is a bit difficult to scrape with no clear html id's etc.

@Gh61
Copy link

Gh61 commented Nov 7, 2022

I was able to extract the api token used for testing api request on DEV API DOC.
When I used it in the script, altrank.py API requests to LC are now working.

I don't know, if everyone got the same token, or is it my personal.
So check yours:

image

@spggooss
Copy link
Contributor

spggooss commented Nov 7, 2022

yeah i found that out as well, but you got a different code then me. It is also different then my created code.

@cyberjunky
Copy link
Owner

Funny the token I found there works here too... so i can 'test' now ;-) Nice!

@cyberjunky
Copy link
Owner

cyberjunky commented Nov 7, 2022

@dangalv I fixed the sorting issue in latest code for altrank, only tested with seperate call, since api.3commas.io is down for me..

@dangalv
Copy link
Contributor Author

dangalv commented Nov 7, 2022

@dangalv I fixed the sorting issue in latest code for altrank, only tested with seperate call, since api.3commas.io is down for me..

Yes, the 3commas api is currently down

image

Then when it is enabled I will keep trying to see what happens

@dangalv
Copy link
Contributor Author

dangalv commented Nov 7, 2022

altrank working
no same luck with galaxyscore

@dangalv
Copy link
Contributor Author

dangalv commented Nov 8, 2022

Great detail of turning off the bot when the credits or day are over :)

@cyberjunky
Copy link
Owner

cyberjunky commented Nov 8, 2022

altrank working no same luck with galaxyscore

I fixed the galaxyscore issue.
Looks like a bug in the LunarCrush API, whenever you sent desc=0 or desc=1 as parameter (which are allowed) the API gives false responses.

@dangalv
Copy link
Contributor Author

dangalv commented Nov 8, 2022

altrank working no same luck with galaxyscore

I fixed the galaxyscore issue. Looks like a bug in the LunarCrush API, whenever you sent desc=0 or desc=1 as parameter (which are allowed) the API gives false responses.

Just yesterday I tried to change that parameter (desc) of galaxyscore to 0 to see if it made it work since I saw that that was what you modified in altrank but it didn't work, apparently in the update you removed it, I hope it works. Thank you

@dangalv dangalv closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants