Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New methods: get and delete activity by id #187

Closed
lrybak opened this issue Jan 22, 2024 · 6 comments
Closed

New methods: get and delete activity by id #187

lrybak opened this issue Jan 22, 2024 · 6 comments

Comments

@lrybak
Copy link

lrybak commented Jan 22, 2024

Hi Ron, thank you for the very useful software. I would like to ask if it would be possible to add a method that allows:

  • retrieving an activity by its ID
  • deleting an activity by its ID

Garmin is not counting my zwift indoor rides to badges trophies and I writing myself kind of script to convert that rides to "garmin virtual rides". Above methods would help me with that.

@thienlamc
Copy link

butailijie

@psdupvi
Copy link
Contributor

psdupvi commented Mar 11, 2024

I can take a look at this if no one else has

@psdupvi
Copy link
Contributor

psdupvi commented Mar 11, 2024

It looks like the function currently called get_activity_evaluation , which accepts an activity id, actually returns the full activity summary JSON. Also, separately, download_activity accepts the activity ID and the format you'd like to download, and downloads the file for you.

I'll create a PR to rename get_activity_evaluation to get_activity, but in the meantime you can use that to retrieve activites by ID

Separately, I'll work on an activity deletion endpoint

@psdupvi
Copy link
Contributor

psdupvi commented Mar 11, 2024

PR #191

@cyberjunky
Copy link
Owner

@lrybak I added the code from @psdupvi to version 0.2.14, can you check?

@cyberjunky
Copy link
Owner

A bit stale, so closing, if still an issue please (re)open one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants