Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
docker-py
library with python_on_whales.Justification:
docker-py
does not (and possibly, will not) support Buildkit. Issue #2230raudi.py
is restricted to using only the simplest Dockerfiles.python_on_whales
is essentially a wrapper around Docker CLI, it is a lot simpler to implement & maintain ( for e.g.check_if_docker_image_exists_local()
inhelper.py
is now just one line! )Changes:
build()
&push()
inraudi.py
with the new syntax. I've tested thebuild()
function & confirmed that it works correctly (see Add "dev" branch for experimental features #20) - but I have not testedpush()
.helper.py
I updated the code incheck_if_docker_image_exists_local()
&check_if_container_runs()
. Please mind my comments in the latter.python_on_whales
inrequirements.txt
I did not removedocker
. This is merely to facilitate debugging & it should be removed before merging intomain
.As far as I'm aware - that should be everything. Apologies if I missed something.