Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex for github tags #5

Merged
merged 1 commit into from Jan 10, 2022
Merged

Fix regex for github tags #5

merged 1 commit into from Jan 10, 2022

Conversation

frost19k
Copy link
Contributor

@frost19k frost19k commented Jan 9, 2022

GitHub tags generally begin with a 'v' - however the current regex (line 83) looks for a digit in the first character. This causes data (on line 90) to be assigned as an empty list.

The change also requires a modification to the input for the sorting algorithm on line 33. Note: stripping 'v' does nothing if 'v' doesn't exist in the input string.

@thelicato thelicato merged commit a7aa6d0 into cybersecsi:main Jan 10, 2022
@thelicato
Copy link
Collaborator

Thanks! We also need to update update our regex to be compatible with x.y.z-text (e.g. 2.0.0-beta) versions. Even though this creates a problem with the get_highest_version_number function. We'll figure it out.

thelicato added a commit that referenced this pull request Jan 11, 2022
Fix regex for github tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants