Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode "~" character in url #10

Closed
raineorshine opened this issue Jul 17, 2019 · 0 comments
Closed

Encode "~" character in url #10

raineorshine opened this issue Jul 17, 2019 · 0 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@raineorshine
Copy link
Contributor

raineorshine commented Jul 17, 2019

Adding the "~" character to the end of a thought breaks the url refresh because it interferes with the Context View url encoding.

Steps to reproduce

  • Add the "~" character to the end of a thought
  • With the cursor on this thought, refresh the page

Current Behavior

  • Cursor disappears
  • Causes a "restoreSelection" error

Expected Behavior

  • When the cursor is on a thought containing "~" and the page is refreshed, the cursor should be restored properly and no error should occur.
  • The "~" should be encoded in the url if it is part of the value of a thought, and decoded when parsed out.
  • Context View url encoding with unencoded "~" should be preserved. ~ is used to encode the Context View state in the URL so that the page can be refreshed and re-open in the Context View.

Enter Ctrl + Shift + S, or click the Screen Shot 2020-03-27 at 7 09 58 AM button in the toolbar to activate the Context View on a given thought. To give a thought multiple contexts, just add it to two different places in the thoughtspace.

@raineorshine raineorshine created this issue from a note in To Do (Todo) Jul 17, 2019
@raineorshine raineorshine removed this from Todo in To Do Sep 26, 2019
@raineorshine raineorshine changed the title Encode ~ in url Encode "~" character in url Jan 11, 2020
@raineorshine raineorshine added this to To do in To Do via automation Jan 11, 2020
@raineorshine raineorshine added the bug Something isn't working label Mar 22, 2020
@raineorshine raineorshine moved this from Ready to In progress in To Do Mar 26, 2020
To Do automation moved this from In progress to Done Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
To Do
Done
Development

No branches or pull requests

2 participants