Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerank subthoughts when sibling collision #25

Closed
raineorshine opened this issue Sep 26, 2019 · 0 comments
Closed

Rerank subthoughts when sibling collision #25

raineorshine opened this issue Sep 26, 2019 · 0 comments
Assignees
Projects

Comments

@raineorshine
Copy link
Contributor

raineorshine commented Sep 26, 2019

When moving (dragging-and-dropping) a thought into a context, that context may have a thought with the same value, which may have different subthoughts (children). When this occurs, the subthoughts from the duplicate thoughts are merged.

Current Behavior

Subthoughts are combined into the destination (dropped) thought without modifying their rank, potentially creating duplicate ranks and/or resulting in an unexpected order.

Expected Behavior

The source subthoughts (drag) should be re-ranked starting with the rank of the last destination subthought (drop) + 1.

e.g. Given the following:

- A
  - B
    - x (rank 7)
    - y (rank 8)
- M
  - B
    - z (rank 4.5)

Moving /M/B into /A should result in the following:

- A
  - B
    - x (rank 7)
    - y (rank 8)
    - z (rank 9)
- M
@raineorshine raineorshine added this to To do in To Do via automation Dec 21, 2019
@raineorshine raineorshine moved this from To do to In progress in To Do Jan 1, 2020
@raineorshine raineorshine changed the title Rerank thoughts when sibling collision Rerank subthoughts when sibling collision Jan 1, 2020
@raineorshine raineorshine removed this from In progress in To Do Jan 11, 2020
@raineorshine raineorshine added this to To do in To Do via automation Jan 11, 2020
@raineorshine raineorshine moved this from Ready to In progress in To Do Mar 2, 2020
To Do automation moved this from In progress to Done Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
To Do
Done
Development

No branches or pull requests

3 participants