Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A One-Line Bug That Could be Easily Fixed #5

Closed
Haoxiang-Wang opened this issue Apr 16, 2020 · 1 comment
Closed

A One-Line Bug That Could be Easily Fixed #5

Haoxiang-Wang opened this issue Apr 16, 2020 · 1 comment

Comments

@Haoxiang-Wang
Copy link

Hi,
First, thanks a lot for this library!

Recently I found a bug in this line of your code:

A = torch.nn.functional.unfold(A, layer.kernel_size)

The bug makes the code not compatible with non-default padding and stride in Conv2d.
Hence, this should be corrected to
A = torch.nn.functional.unfold(A, layer.kernel_size,padding=layer.padding,stride=layer.stride)

Best regards,
Haoxiang

@Haoxiang-Wang
Copy link
Author

I found this issue is already posted by another user.
#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant