New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DefaultGatherer to collect standard metrics #352

Closed

4 tasks done

zoetrope opened this issue Jun 8, 2020 · 0 comments

Closed

4 tasks done

Add DefaultGatherer to collect standard metrics #352

zoetrope opened this issue Jun 8, 2020 · 0 comments

Member

zoetrope commented Jun 8, 2020 •

edited by ymmt2005

Loading

What

I want to collect standard and runtime metrics.

How

Add prometheus.DefaultGatherer to promhttp.HandlerFor call.

ref:

https://github.com/prometheus/client_golang/blob/4739e9cf8cd673602da0facb331c6b8393559b46/prometheus/promhttp/http.go#L76
cke/metrics/collector.go

Line 71 in 9af11fa

handler := promhttp.HandlerFor(registry,

Checklist

Finish implentation of the issue
Test all functions
Have enough logs to trace activities
Notify developers of necessary actions

The text was updated successfully, but these errors were encountered:

zoetrope mentioned this issue

Add default gatherer #353

Merged

ymmt2005 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment