Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rook: support topologySpreadConstraints #664

Closed
4 tasks done
satoru-takeuchi opened this issue Nov 28, 2019 · 1 comment
Closed
4 tasks done

Rook: support topologySpreadConstraints #664

satoru-takeuchi opened this issue Nov 28, 2019 · 1 comment
Assignees
@satoru-takeuchi

Comments

@satoru-takeuchi
Copy link
Contributor

satoru-takeuchi commented Nov 28, 2019 •
edited by ymmt2005

What

It's necessary to support topologySpreadConstraints to spread OSDs among failure domains as much as possible. The detail is written in the following document.
https://github.com/rook/rook/blob/369958e08bbbd8f0058a288e2f4444246d22a391/cluster/examples/kubernetes/ceph/cluster-on-pvc.yaml#L54

In addition, the meaning of topologySpreadConstraints is written in the following document.
https://kubernetes.io/docs/concepts/workloads/pods/pod-topology-spread-constraints/

How

Fix the upstream Rook.

issue:
rook/rook#4387

PR:
rook/rook#5138

Checklist

  • Finish implementation of the issue
  • Test all functions
  • Have enough logs to trace activities
  • Notify developers of necessary actions
@satoru-takeuchi satoru-takeuchi self-assigned this Nov 28, 2019
@satoru-takeuchi satoru-takeuchi added the wait-for-external-factors Wait for factors that are external to Neco label Dec 26, 2019
@satoru-takeuchi satoru-takeuchi added wait-for-external-factors Wait for factors that are external to Neco and removed wait-for-external-factors Wait for factors that are external to Neco labels Jan 17, 2020
@masa213f
Copy link
Contributor

This issue would be closed at Rook v1.3.
This will be pending until topologySpreadConstraints become beta.

@satoru-takeuchi satoru-takeuchi added wait-for-external-factors Wait for factors that are external to Neco and removed wait-for-external-factors Wait for factors that are external to Neco labels Mar 19, 2020
@satoru-takeuchi satoru-takeuchi added wait-for-external-factors Wait for factors that are external to Neco and removed wait-for-external-factors Wait for factors that are external to Neco labels Apr 1, 2020
@ymmt2005 ymmt2005 closed this as completed Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@satoru-takeuchi satoru-takeuchi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ymmt2005 @satoru-takeuchi @masa213f