-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: React 17 support #538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix failing tests?
@koba04
Which is better? I seem that 1. way leads to breaking backward compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🎉
@nissy-dev I prefer the option 1. But we should provide an announcement for the breaking change that we can still use the classic JSX syntax (
|
53ae89d
to
b545570
Compare
README.md
Outdated
@@ -123,3 +123,13 @@ module.exports = { | |||
``` | |||
|
|||
We also provide `@cybozu/eslint-config/presets/kintone-customize-es5-prettier` to use it with `prettier`. | |||
|
|||
## ⚠️ Class JSX Syntax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nissy-dev
Thank you! I have an additional request 🙏
I want to add the ## React Support
section and move this to the upper of the ## For kintone customize developers
section.
## ⚠️ Class JSX Syntax | |
## React Support | |
### ⚠️ Classic JSX Syntax |
Could you apply the change and move the section to the upper of the ## For kintone customize developers
section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@koba04
I fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 👏 👏 Great works!!!
Fixed #450
I added "plugin:react/jsx-runtime" for React 17 based on the following statement.
https://github.com/yannickcr/eslint-plugin-react#configuration