Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE(react): add react/no-unstable-nested-components rule as error #665

Merged

Conversation

yujialves
Copy link
Contributor

@yujialves yujialves commented May 9, 2023

To prevent performance degradation, I added a rule to prohibit defining components within components in React.
Defining components within components can cause unnecessary re-rendering.

Copy link
Contributor

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@koba04 koba04 merged commit 559bfac into cybozu:master May 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants