Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repository DX issue - mutable Select #137

Closed
wolfy-j opened this issue Oct 6, 2022 · 3 comments
Closed

Repository DX issue - mutable Select #137

wolfy-j opened this issue Oct 6, 2022 · 3 comments
Assignees
@roxblnfk

Comments

@wolfy-j
Copy link
Contributor

wolfy-j commented Oct 6, 2022

We need to add more visual disclosure that user should NOT modify $select property of repository (or make it private) to build local queries.
@roxblnfk
Copy link
Member

roxblnfk commented Oct 6, 2022

We can make it readonly but in this case we need to bump PHP versoin

@wolfy-j
Copy link
Contributor Author

wolfy-j commented Oct 6, 2022

Can we at least update docs for now?

@roxblnfk
Copy link
Member

roxblnfk commented Oct 6, 2022

Yes we can

This was referenced Oct 6, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roxblnfk roxblnfk

Labels
None yet
Projects
Cycle
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wolfy-j @roxblnfk