Moving typing from entity to mapping schema

[SerafimArts]

I think that types should be defined in the schema, not in Entity. In this case, we can allow for more flexible behavior (have several different types in the same entity depending on the repository source). In that case, when we need to guarantee the types in entity, we can use the PHP 7.4+ properties typing.

Actual

class Entity
{
    /** @column(type=string) */
    protected $some;
}

new Schema([
    'user' => [Schema::COLUMNS  => ['some']]
]);

Expected

class Entity
{
    protected $some;
}

new Schema([
    'user' => [Schema::COLUMNS  => ['some' => 'string']]
]);

[wolfy-j]

It is actually already in schema, see section TYPECAST. The column type drives this value as default and tells the driver how to configure the database.

[SerafimArts]

Hmmm... In this case, my proposal becomes irrelevant =)

[wolfy-j]

I can also find your original comments about using one entity for two sources. This is possible as well, check Classless example in tests :)

[SerafimArts]

@wolfy-j I understood this after I started reading the source code =)

Therefore, instead of closing the issue, I was just corrected it.

[wolfy-j]

OK. I will try to explain it all in the documentation but the hard separation between the entity and it's mapping was a very critical aspect of the design.

I assume it will be more questions when we will describe it in details (60 pages :( ).

Please let me know if you have any high-level questions in the meantime, I would glad to make sure that direction is correct and we do not miss anything.

[SerafimArts]

kk. We still have time to talk about this topic on phprussia conf ;)

[wolfy-j]

LOL, that too.