Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCA-Diversity] Bring typescript src into core-flavor #92

Closed
nickbalestra opened this issue Apr 8, 2017 · 2 comments · Fixed by #102
Closed

[CCA-Diversity] Bring typescript src into core-flavor #92

nickbalestra opened this issue Apr 8, 2017 · 2 comments · Fixed by #102
Assignees
@jvanbruegge
Labels
in progress

Comments

@nickbalestra
Copy link
Collaborator

nickbalestra commented Apr 8, 2017 •
edited
Loading

Once #91 got merged
@jvanbruegge jvanbruegge self-assigned this Apr 10, 2017
@nickbalestra nickbalestra mentioned this issue Apr 10, 2017
Open
@jvanbruegge
Copy link
Collaborator

@nickbalestra I dont think the replacements work language agnostic, for typescript I would have to add quite a few
I will move the replacements.js to the template folder and create a new one for typescript

@nickbalestra
Copy link
Collaborator Author

Yes, maybe we could also think of better name, but agree that those should be within the template/src/<language>

@jvanbruegge jvanbruegge mentioned this issue Apr 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvanbruegge jvanbruegge

Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Typescript cyclejs-community/create-cycle-app
2 participants
@nickbalestra @jvanbruegge