Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycle/DOM isolateModule is being bailed out be chrome profiler #383

Closed
tusharmath opened this issue Aug 6, 2016 · 2 comments
Closed

Cycle/DOM isolateModule is being bailed out be chrome profiler #383

tusharmath opened this issue Aug 6, 2016 · 2 comments

Comments

@tusharmath
Copy link

tusharmath commented Aug 6, 2016

version: 12.0.3

Dom driver performance suffers because of the try catch being used inside the loop.
https://github.com/cyclejs/cyclejs/blob/master/dom/src/isolateModule.ts#L26

screen shot 2016-08-06 at 3 00 08 pm

Instead of using try/catch putting a simple if condition such as —

 if (!result.value) {
  hasNext = false
  break
}

Makes the driver perform much better. More details — GoogleChrome/devtools-docs#53

@tusharmath tusharmath changed the title Cycle/DOM performance issues Cycle/DOM isolateModule is being bailed out be chrome profiler Aug 6, 2016
@wclr
Copy link
Contributor

wclr commented Aug 6, 2016

try catch in this case is really ugly
usage of try catch (along with setTimeout) should be regulated at least by the Supreme Court or even by International Court of Justice.

as well as usage for break and continue

@staltz
Copy link
Member

staltz commented Aug 25, 2016

Thank you @tusharmath
Sometimes my brain equals poop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants