Rendering the same content on both server and client causes a loss of events

[krainboltgreene]

Code to reproduce the issue:

https://github.com/krainboltgreene/deushack

Expected behavior:

If I click on an element I should receive a click event.

Actual behavior:

Nothing happens

Versions of packages used:

Latest

[krainboltgreene]

I'm able to hack around this by either rendering something different after client side has booted. For example, if I add a data-created-at=new Date() to a dom tree element I suddenly get my events.

I'm guessing this is as much snabbdom as cycle/dom?

[staltz]

Hi @krainboltgreene
Thanks for letting us know about this.
I think I can reproduce this by updating libraries in examples/advanced/isomorphic and not having click events preventDefault'd on client side.

[krainboltgreene]

Let me know if I can help with this at all.

[staltz]

Thanks @krainboltgreene. I think it would help to discover what was the lowest versions of cycle/dom, cycle/run, and cycle/html where the bug happens, and the highest versions of cycle/dom|run|html where the bug does not happen.

[krainboltgreene]

Will do when I get home.

[staltz]

Any updates on this issue? I would like to solve it (and have some time for solving it) but I need to know first if it's a real issue in the framework.

[Tzelon]

The issue is still relevant I create a repo to reproduce the problem
https://github.com/Tzelon/cycle.js-ssr-bug

[jvanbruegge]

@Tzelon You have to remove the sinks.DOM = sinks.DOM.drop(1). It wont do anything to the DOM, but it will initialize the isolation scopes within cycle
Just commenting out this line and your repo works

[Tzelon]

Thanks.
I thought the drop part should be there so we don't re-render the DOM.

[jvanbruegge]

Snabbdom figures out that the dom did not change and does not rerender

[jvanbruegge]

As I had no issues getting the excellent example of @Tzelon to work and the original repro segfaults, I will close this issue.
As far as I can tell is the original issue fixed with @cycle/dom v21

[Tzelon]

Thanks, @jvanbruegge this solved my issue.
Can we update the isomorphic example?
The client.js code from my repo copied from there https://github.com/cyclejs/cyclejs/blob/master/examples/advanced/isomorphic/client.js

[jvanbruegge]

Yeah, I will update all examples in the next weeks (#802)