Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-mail for poll type needs to include a link to the message #939

Closed
mvl22 opened this issue Mar 10, 2020 · 2 comments
Closed

E-mail for poll type needs to include a link to the message #939

mvl22 opened this issue Mar 10, 2020 · 2 comments

Comments

@mvl22
Copy link
Member

@mvl22 mvl22 commented Mar 10, 2020

According to
https://camcycle.cyclescape.org/threads/227#message_70529

the e-mail that goes out for a poll doesn't actually include a link to it.

@nikolai-b

This comment has been minimized.

Copy link
Contributor

@nikolai-b nikolai-b commented Mar 10, 2020

https://www.staging.cyclescape.org/rails/mailers/thread_mailer_mailer/new_poll_message

Like all new notifications the footer contains

From Cyclescape discussion thread.

with a link to the message. This is what we do on other message types, would you like poll to do something different or should we change the footer?

@mvl22

This comment has been minimized.

Copy link
Member Author

@mvl22 mvl22 commented Mar 10, 2020

I think on this specific case, we should repeat the link in the body of the message - it feels a bit odd otherwise to have a poll which is just text.

Add something like:

Vote at:
<link-with-#message-id>

after the options.

@nikolai-b nikolai-b closed this in 5444b2c Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.