Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open_threads API parameter is not helpful for issues with zero threads #942

Closed
mvl22 opened this issue Mar 24, 2020 · 3 comments
Closed

Comments

@mvl22
Copy link
Member

mvl22 commented Mar 24, 2020

The aim of the open_threads parameter is to enable filtering out those issues whose threads have all been closed, i.e. the issue is resolved.

However, it turns out this means that issues with zero threads (i.e. no discussion yet) are also therefore treated as resolved!

Can I suggest we remove open_threads and replace it with just is_open/open_issues/open_only or whatever?

There is no backwards compatibility as the only API user of this is code under my control that I can easily change.

@nikolai-b
Copy link
Contributor

I'm using an inner join so zero threads do not count as open. I'm not checking if the thread is public though...

@mvl22
Copy link
Member Author

mvl22 commented Mar 24, 2020

Could you revert this specific change - it has suddenly vastly reduced the number of issues.

We'll look at a better fix shortly.

@nikolai-b nikolai-b reopened this Mar 25, 2020
@mvl22
Copy link
Member Author

mvl22 commented Mar 25, 2020

Great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants