Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override of ip configuration #285

Closed
nicolasThal opened this issue May 3, 2022 · 3 comments · Fixed by #293
Closed

Override of ip configuration #285

nicolasThal opened this issue May 3, 2022 · 3 comments · Fixed by #293
Assignees
Labels
Type: Bug Something isn't working

Comments

@nicolasThal
Copy link

General information:

  • Operating System: Ubuntu 22.04
  • Terracognita version / tag: v0.7.4
  • Did you build Terracognita from sources or did you use the Docker image: Download from sources

Describe the bug:

I have exported my configuration for a cloudSql instance on GCP. I have 3 firewall rules to allow 3 different IP to directly query the database instance.

In the tfstate file, the correct configuration is set. I can see the three different IP address with their associated name.

In the module file, I have 3 entries in the ip_configuration.authorized_networks key.
When I look closer, I see that the generated variable name is the same for all three entries :

    ip_configuration {
      authorized_networks {
        name  = var.google_sql_database_instance_infra_services_uat_ssd_settings_ip_configuration_authorized_networks_name
        value = var.google_sql_database_instance_infra_services_uat_ssd_settings_ip_configuration_authorized_networks_value
      }

      authorized_networks {
        name  = var.google_sql_database_instance_infra_services_uat_ssd_settings_ip_configuration_authorized_networks_name
        value = var.google_sql_database_instance_infra_services_uat_ssd_settings_ip_configuration_authorized_networks_value
      }

      authorized_networks {
        name  = var.google_sql_database_instance_infra_services_uat_ssd_settings_ip_configuration_authorized_networks_name
        value = var.google_sql_database_instance_infra_services_uat_ssd_settings_ip_configuration_authorized_networks_value
      }

Should it be my responsibility to update all of those variables ?

If not, could you help me creating a fix for this issue ?

@nicolasThal nicolasThal added the Type: Bug Something isn't working label May 3, 2022
@xescugc
Copy link
Member

xescugc commented May 13, 2022

Ok we also identified that already on our side and I'll work on fixing it :) I thought we already had it fixed as I recall conversations about it with other colleagues.

@nicolasThal
Copy link
Author

Thank you @xescugc for your help.

I will test it as soon as I can !

@xescugc
Copy link
Member

xescugc commented May 16, 2022

Is on master now :) It'll be included on the next release ( no date yet )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants