Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide plugin in Gradle Plugin Portal #13

Closed
stefanneuhaus opened this issue Aug 5, 2019 · 12 comments
Closed

Provide plugin in Gradle Plugin Portal #13

stefanneuhaus opened this issue Aug 5, 2019 · 12 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@stefanneuhaus
Copy link
Contributor

Having the plugin available in the Gradle Plugin Portal allows for the applying the plugin using the plugins DSL. If possible, this is often the preferred way.

If not required, having the plugin's build use Gradle is probably the most obvious way. This also comes with other benefits like support for easily testing the plugin during the build.

@stevespringett
Copy link
Member

If there is a Maven way of adding the plugin to the plugin portal, this project accepts pull requests. However, the project will not be migrating from maven to gradle.

@stevespringett stevespringett added help wanted Extra attention is needed enhancement New feature or request labels Aug 6, 2019
@sschuberth
Copy link
Contributor

However, the project will not be migrating from maven to gradle.

Hmm, while I respect your personal preference here, does that restriction really make sense from a technical perspective? To me, it feels more native to build a Gradle plugin with Gradle, and you could make use of helpers like the Java Gradle Plugin Development Plugin.

@stevespringett
Copy link
Member

I agree, however, this project doesn't have a maintainer that knows Gradle. If that changes in the future, I have no objection, but if the maintainer is going to continue to be myself, I need something I know how to maintain (which is not Gradle).

@llamahunter
Copy link
Contributor

would you be open to having a separate gradle build that does the portal publishing?

@stevespringett
Copy link
Member

Certainly, as long as it's independent. I'll likely need docs on how to execute the build

@llamahunter
Copy link
Contributor

see #36

@llamahunter
Copy link
Contributor

With the merge of #36, will there be an upcoming publishing of the plugin to the Gradle Plugin Portal? New version, or 1.1.1?

@llamahunter
Copy link
Contributor

When will the plugin get published to the gradle plugin portal?

@stevespringett
Copy link
Member

Its been published, but it doesn't seem to be automated. Received the following after a successful publish:

Publishing plugin org.cyclonedx.bom version 1.1.2
Thank you. Your new plugin org.cyclonedx.bom has been submitted for approval by Gradle engineers. The request should be processed within the next 24 hours, at which point you will be contacted via email.

Hopefully this is a one-time thing and not for every update.

@llamahunter
Copy link
Contributor

I think I covered that in the document. It's a one time thing to approve 'ownership' of the plugin's namespace.

If this is the first time the plugin has been published, the name may need to be approved by the portal maintainers. This typically takes about 12 hours during the work week. You will see on your portal user console page that your plugin is marked 'Pending approval'. After it is approved, the API credentials used to publish will 'own' the plugin name, and plugins will be available in the portal immediately after publishing.

@stevespringett
Copy link
Member

Thanks @llamahunter for all the info and quality PR.

https://plugins.gradle.org/plugin/org.cyclonedx.bom

@lock
Copy link

lock bot commented Dec 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants