Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix local install #71

Closed
jkowalleck opened this issue Aug 23, 2022 · 1 comment
Closed

fix local install #71

jkowalleck opened this issue Aug 23, 2022 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Aug 23, 2022

this package ships a shrinkwrap. this is totally fine as long as downstream users install via npm i -g
if they install locally via npm i -D , they will install this package and all its dev-dependencies - which is unintended.

therefore, the shipped shrinkwrap must be stripped from dev dependencies.

it is no option to strip the feature of local installations.
because tis enables proper versioning of the tool and its dependencies via renovate, dependabot and other dependency watchers ...

@jkowalleck jkowalleck added this to the v1.0 milestone Aug 23, 2022
@jkowalleck jkowalleck added the bug Something isn't working label Aug 23, 2022
@jkowalleck
Copy link
Member Author

possible solution: remove the shrinkwrap from the project
-> this would casue clients to install ANY version, not the one that was properly tested with

have theshrinkwrap be created with prod-data only, ala

rm -rf package-lock.json npm-shrinkwrap.json
npm shrinkwrap --omit --dev 
## the shrinkwrap is created basd on pruned `npm_modules` folder ... 

jkowalleck added a commit that referenced this issue Aug 23, 2022
see #71

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Aug 23, 2022
see #71

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck added a commit that referenced this issue Aug 23, 2022
see #71

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant