Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rootUrl is not defined when writing configuration template #65

Closed
reppners opened this issue Feb 7, 2020 · 2 comments
Closed

rootUrl is not defined when writing configuration template #65

reppners opened this issue Feb 7, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@reppners
Copy link

reppners commented Feb 7, 2020

servers in the open api spec file is not evaluated as per https://swagger.io/docs/specification/api-host-and-base-path/. The handlebars template for the api configuration shows the default configuration rootUrl should be populated by the template context variable rootUrl but it isn't.

My use case is that the OpenApi servers spec contains a single member that has a relative basepath set as url. This should be reflected in the generated code as no manual basepath configuration should be necessary.

If you're accepting PRs on this let me know and I'm happy to contribute!

@luisfpg luisfpg added the bug Something isn't working label Feb 19, 2020
@luisfpg
Copy link
Contributor

luisfpg commented Feb 19, 2020

Actually, the root URL was never being read from the specification.
Will be fixed in 0.8.0.

@reppners
Copy link
Author

Awesome! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants