Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pipe(take(1)) or pipe(first()) for all methods since http will never give a second result #249

Closed
gideruette opened this issue Aug 31, 2020 · 1 comment

Comments

@gideruette
Copy link

I suggest that we can add a take(1) or the operator first() to methods pipes so that we don't need to unsubscribe observable. Http won't give us a second value after return

@andresbm05
Copy link

That is not needed. Http request Observables returned by HttpClient are self-completed after emitting the response, so you dont need to unsubscribe and it will not cause memory leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants