Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Dependency Table Column #1710

Closed
bennibbelink opened this issue Mar 26, 2024 · 5 comments · Fixed by #1735
Closed

New Dependency Table Column #1710

bennibbelink opened this issue Mar 26, 2024 · 5 comments · Fixed by #1735
Assignees
Milestone

Comments

@bennibbelink
Copy link
Contributor

In the table of dependencies it might be helpful to add a new column to identify which options require which dependencies.

@bennibbelink bennibbelink self-assigned this Mar 26, 2024
@gonuke gonuke added this to the v1.6 milestone Mar 29, 2024
@abachma2
Copy link
Member

abachma2 commented Apr 8, 2024

Do you need any help on this one @bennibbelink ?

@bennibbelink
Copy link
Contributor Author

Sure! I just hadn't gotten around to this yet but you're more than welcome to take over this issue

@abachma2
Copy link
Member

abachma2 commented Apr 9, 2024

When you say options, you mean the build options, like --allow-milps, right?

@bennibbelink
Copy link
Contributor Author

Correct. In the standard dependencies table I think the coin-or libraries are the only "options", what are your thoughts about combining it with the "optional dependency" table below it?

@abachma2
Copy link
Member

We definitely should revisit what's listed as required vs optional, as we've discussed in the slack. I think we should keep the dependency tables separate. We may also want to revisit the conda install command in the README if some of those dependencies are truly optional. It's a lot of packages and as we saw in doing some of the updates for v1.6, it's non trivial to make sure our documentation has correct versions for all of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants