Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylc review: improve CLI #2928

Closed
sadielbartholomew opened this issue Jan 16, 2019 · 4 comments
Closed

cylc review: improve CLI #2928

sadielbartholomew opened this issue Jan 16, 2019 · 4 comments

Comments

@sadielbartholomew
Copy link
Collaborator

As outlined in #2924 (comment). For useful feedback we should notify users when any arguments passed have no influence on the code logic, particularly as I anticipate it could often be assumed a suite argument can be passed to this utility to open directly onto that suite's listing page, e.g:

$ cylc review mysuite
host=0.0.0.0
pid=7395
port=8080
``
@sadielbartholomew sadielbartholomew added this to the soon milestone Jan 16, 2019
@hjoliver
Copy link
Member

hjoliver commented Jan 16, 2019

IMO we should require an explicit argument to get server status, as I had assumed was the case: cylc review status. I think (although not 100% sure) that's standard for daemons and services, both standalone and those managed by systemctl on Linux, for instance. Then perhaps cylc review (no args) could either fail or try to open Cylc Review on the current suite?

@hjoliver hjoliver mentioned this issue Jan 17, 2019
6 tasks
@matthewrmshin
Copy link
Contributor

We can do this now with our own logic, or we can wait until we move away from optparse to argparse when we drop support for Python 2.6. Use of argparse should allow us to define better options or argument choices.

@sadielbartholomew sadielbartholomew changed the title cylc review: acknowledge ineffectual CLI arguments cylc review: improve CLI Jan 17, 2019
@sadielbartholomew
Copy link
Collaborator Author

(I've renamed this Issue to be more accurate given the previous comments.)

I think it is best to wait until the Python 3 port is done, hence I will not assign myself & tackle it, but someone could always do so pre-migration if they wish.

@matthewrmshin matthewrmshin modified the milestones: soon, cylc-8.0.0 Mar 11, 2019
@hjoliver hjoliver modified the milestones: cylc-8.0.0, cylc-7.8.x Aug 4, 2021
@hjoliver
Copy link
Member

hjoliver commented Aug 4, 2021

closing as wontfix. cylc review won't be developed further, pending integration with cylc-ui.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants