Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task hold/release needs to be flow-specific #4277

Open
hjoliver opened this issue Jun 22, 2021 · 6 comments · May be fixed by #5698
Open

Task hold/release needs to be flow-specific #4277

hjoliver opened this issue Jun 22, 2021 · 6 comments · May be fixed by #5698
Assignees
@hjoliver
Milestone
8.4.0

Comments

@hjoliver
Copy link
Member

Follow-up to #4238
@hjoliver hjoliver added this to the 8.x milestone Jun 22, 2021
@hjoliver hjoliver mentioned this issue Jun 22, 2021
Merged
7 tasks
@MetRonnie
Copy link
Member

MetRonnie commented Jun 22, 2021 •
edited

From that PR:

I think we will want to add the "flow label" into the tasks_to_hold set in order to handle the situation where we have the same
task from different flows. E.G. the user might want to hold one flow but the another

@hjoliver
Copy link
Member Author

hjoliver commented Aug 15, 2023 •
edited

Probably rather simple to implement. I'll take a look ...

@hjoliver hjoliver self-assigned this Aug 15, 2023
@ColemanTom
Copy link
Contributor

Just to check. Am I correct that being able to hold a specific flow, should also mean that cylc release shoul be able to operate on a specific flow too?

@hjoliver
Copy link
Member Author

hjoliver commented Aug 17, 2023 •
edited

Yes, correct (I'll update the title).

@hjoliver hjoliver changed the title Task hold needs to be flow-specific Task hold/release needs to be flow-specific Aug 17, 2023
@hjoliver hjoliver modified the milestones: cylc-8.x, cylc-8.3.0 Aug 17, 2023
@hjoliver hjoliver linked a pull request Aug 17, 2023 that will close this issue
Open
10 tasks
@TomekTrzeciak
Copy link
Contributor

What is the expected/planned behaviour when anther flow merges with the held one?

@hjoliver
Copy link
Member Author

The merged task will be held, I think. Similarly, if you hold flow 3 (say) a merged task belonging to flows (2,3) should be held.

@oliver-sanders oliver-sanders modified the milestones: cylc-8.3.0, cylc-8.4.0 Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjoliver hjoliver

Labels
None yet
Projects
None yet
Milestone
8.4.0
Development

Successfully merging a pull request may close this issue.

Flow-specific hold/release hjoliver/cylc-flow
5 participants
@hjoliver @TomekTrzeciak @ColemanTom @oliver-sanders @MetRonnie