Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylc release: only need to match in the tasks-to-hold list #5750

Open
hjoliver opened this issue Sep 30, 2023 · 1 comment · May be fixed by #5752
Open

cylc release: only need to match in the tasks-to-hold list #5750

hjoliver opened this issue Sep 30, 2023 · 1 comment · May be fixed by #5752
Assignees
Labels
could be better Not exactly a bug, but not ideal.
Milestone

Comments

@hjoliver
Copy link
Member

hjoliver commented Sep 30, 2023

Currently the hold/release commands both work like this:

  • glob pattern args:
    • find matching task proxies in the task pool
    • add/remove their IDs from the tasks-to-hold list
    • action the hold/release on the matching task proxies
  • specific task ID args:
    • add/remove the IDs from tasks-to-hold list
    • action the hold/release for any of those that exist in the task pool

HOWEVER, we can only release tasks that are already held, so "release" actually only needs to look at the tasks-to-hold list:

  • glob pattern or specific ID:
    • find matching IDs in the tasks-to-hold list, and remove them
    • action the release for any of those that exist in the task pool

NOTE this allows releasing a glob-hold by using the same glob, even if it no longer matches in the task pool - which can be important in partial graph rewind scenarios. [I have a real example, which motivated this Issue].

@hjoliver hjoliver added this to the cylc-8.3.0 milestone Sep 30, 2023
@hjoliver hjoliver added the could be better Not exactly a bug, but not ideal. label Sep 30, 2023
@hjoliver hjoliver self-assigned this Oct 2, 2023
@hjoliver
Copy link
Member Author

hjoliver commented Oct 2, 2023

Minor tweak to the above - we still need to consider the task pool as well, for state selectors.

@hjoliver hjoliver modified the milestones: cylc-8.3.0, cylc-8.4.0 Mar 14, 2024
@hjoliver hjoliver modified the milestones: cylc-8.4.0, cylc-8.3.0 Apr 8, 2024
@hjoliver hjoliver modified the milestones: 8.3.0, 8.4.0 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant