Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow-state: check latest instance for status #5143

Open
hjoliver opened this issue Sep 18, 2022 · 1 comment · May be fixed by #5809
Open

workflow-state: check latest instance for status #5143

hjoliver opened this issue Sep 18, 2022 · 1 comment · May be fixed by #5809
Assignees
@hjoliver
Labels
bug
Milestone
8.3.0

Comments

@hjoliver
Copy link
Member

hjoliver commented Sep 18, 2022 •
edited

The task_states DB table gets a new entry for a given task ID if its flow numbers change. That's because we use the table to extract flow-wait status for historical tasks that already ran in this flow.

(For a given flow, the submit number of a task ID updates but we don't get a new entry).

cylc workflow-state wrongly assumes that any non-null query result indicates status achieved. It should only check the result for the latest matching record in the table (i.e. latest submit number).
@hjoliver hjoliver added the bug label Sep 18, 2022
@hjoliver hjoliver added this to the cylc-8.0.3 milestone Sep 18, 2022
@hjoliver hjoliver self-assigned this Sep 19, 2022
@hjoliver hjoliver mentioned this issue Sep 19, 2022
Closed
8 tasks
@hjoliver hjoliver changed the title task states table: update flow numbers workflow-state: check lastest-flow instance for status Sep 19, 2022
@hjoliver hjoliver changed the title workflow-state: check lastest-flow instance for status workflow-state: check lastest instance for status Sep 19, 2022
@oliver-sanders oliver-sanders modified the milestones: cylc-8.0.3, cylc-8.0.4 Oct 12, 2022
@oliver-sanders oliver-sanders modified the milestones: cylc-8.0.4, cylc-8.1.x Dec 6, 2022
@hjoliver hjoliver modified the milestones: cylc-8.1.x, cylc-8.2.0 Jun 13, 2023
@oliver-sanders oliver-sanders modified the milestones: cylc-8.2.0, cylc-8.3.0 Jul 11, 2023
@oliver-sanders oliver-sanders modified the milestones: cylc-8.3.0, cylc-8.2.1 Jul 24, 2023
@oliver-sanders oliver-sanders modified the milestones: cylc-8.2.1, cylc-8.2.2 Aug 14, 2023
@oliver-sanders oliver-sanders modified the milestones: cylc-8.2.2, cylc-8.2.3 Oct 4, 2023
@oliver-sanders oliver-sanders modified the milestones: cylc-8.2.3, cylc-8.2.4 Nov 1, 2023
@oliver-sanders oliver-sanders modified the milestones: cylc-8.2.4, 8.2.5 Jan 8, 2024
@oliver-sanders oliver-sanders modified the milestones: cylc-8.2.5, 8.2.x Mar 26, 2024
@hjoliver hjoliver linked a pull request Apr 19, 2024 that will close this issue
Open
8 tasks
@hjoliver hjoliver changed the title workflow-state: check lastest instance for status workflow-state: check latest instance for status Apr 26, 2024
@MetRonnie MetRonnie modified the milestones: 8.2.x, 8.3.0 May 16, 2024
@MetRonnie
Copy link
Member

MetRonnie commented Jun 4, 2024 •
edited

If this is the blocker for 8.3.0 at NIWA, could you consider splitting off the fix for this from the rest of #5809 into a new PR, and do the rest at 8.4.0?

#5809 is a rather complex PR and will take a while to review, and we're hesitant to release 8.3.0 immediately after without any testing period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjoliver hjoliver

Labels
bug
Projects
None yet
Milestone
8.3.0
3 participants
@hjoliver @oliver-sanders @MetRonnie