Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: auto upgrade "suite_state" to "workflow_state" in compat mode #5835

Closed
oliver-sanders opened this issue Nov 21, 2023 · 0 comments · Fixed by #5864
Closed

config: auto upgrade "suite_state" to "workflow_state" in compat mode #5835

oliver-sanders opened this issue Nov 21, 2023 · 0 comments · Fixed by #5864
Assignees
@markgrahamdawson
Labels
could be better Not exactly a bug, but not ideal. small
Milestone
8.3.0

Comments

@oliver-sanders
Copy link
Member

oliver-sanders commented Nov 21, 2023 •
edited

The suite_state xtrigger was renamed to workflow_state, this breaks Cylc 7-8 interoperability.

Ideally, we would back-support the old name in compat mode.

Suggestions:

  • Hack the config to replace "suite_state" with "workflow_state" and print a deprecation message (when not in compat mode).
  • Add an xtrigger called suite_state which imports workflow_state and logs a deprecation message (when not in compat mode).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markgrahamdawson markgrahamdawson

Labels
could be better Not exactly a bug, but not ideal. small
Projects
None yet
Milestone
8.3.0
Development

Successfully merging a pull request may close this issue.

added suite state xtrigger for back-compat markgrahamdawson/cylc-flow
2 participants
@markgrahamdawson @oliver-sanders