Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove (or update and use?) the bundled OrderedDict? #2197

Closed
hjoliver opened this issue Mar 9, 2017 · 2 comments
Closed

Remove (or update and use?) the bundled OrderedDict? #2197

hjoliver opened this issue Mar 9, 2017 · 2 comments
Assignees
@hjoliver
Labels
small
Milestone
cylc-7.2.1

Comments

@hjoliver
Copy link
Member

hjoliver commented Mar 9, 2017 •
edited

Might be worth checking performance of latest version - https://pypi.python.org/pypi/ordereddict - if there is any advantage, install it properly, else remove from Cylc (which leaves lib/parsec/OrderedDict.py - slow? - for those still on Python 2.6...)
@hjoliver hjoliver added the small label Mar 9, 2017
@hjoliver hjoliver added this to the soon milestone Mar 9, 2017
@matthewrmshin
Copy link
Contributor

Our performance tests of cylc on Python 2.6 suggest that performance is adequate, so I suggest that we should just remove the bundled code.

@hjoliver hjoliver self-assigned this Mar 9, 2017
@hjoliver
Copy link
Member Author

hjoliver commented Mar 9, 2017

Roger that.

@hjoliver hjoliver mentioned this issue Mar 9, 2017
Merged
@hjoliver hjoliver modified the milestones: next release, soon Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjoliver hjoliver

Labels
small
Projects
None yet
Milestone
cylc-7.2.1
Development

No branches or pull requests
2 participants
@matthewrmshin @hjoliver