Record linearization in database #2213
Conversation
|
Much as I dislike creating more issues (we almost got down to 100 for a while...) when #2075 is closed by this PR, we should probably record the first bullet point of #2075 (comment) in a new one? |
tests/database/00-simple.t
Outdated
| sqlite3 "${DB_FILE}" 'SELECT namespace, linearization FROM linearization ORDER BY namespace' \ | ||
| >"${NAME}" | ||
| cmp_ok "${TEST_SOURCE_DIR}/${TEST_NAME_BASE}/${NAME}" "${NAME}" | ||
|
|
There was a problem hiding this comment.
Maybe rebase this branch to master and protect the sqlite3 call as documented here: https://github.com/cylc/cylc/blob/master/bin/cylc-test-battery#L77 (else we might forget...)
|
Also wondering if |
arjclark
force-pushed
the
2075.linearisation
branch
from
4d20dff
to
765ab4e
Compare
|
@hjoliver - rebased and changed to "inheritance" from "linearization" |
Yeah, that'd probably be for the best. |
|
On reload, I wonder if it will be safer to delete everything and re-insert them all again. |
Just noted in #1984 that shared dependency objects might ultimately be the best route to making family information available to external tools (I haven't thought this through in detail though...) |
(huh, three different pronunciations of "ough" in one sentence 😬) |
So, I'm in two minds about this which is why I ended up going with "INSERT or REPLACE" as I didn't want to lose details for tasks that had run previously but were no longer in the suite. @hjoliver - thoughts? |
|
As I recall we can't change inheritance structure on reload, so I don't think reinsert is needed (or has that changed?) |
In which case, good to go. |
Move logic after merging cylc#2213.
Move logic after merging cylc#2213.
Move logic after merging cylc#2213.
Move logic after merging cylc#2213.
Move logic after merging cylc#2213.
Move logic after merging cylc#2213.
Move logic after merging cylc#2213.
Move logic after merging cylc#2213.
Move logic after merging cylc#2213.
Move logic after merging cylc#2213.
Move logic after merging cylc#2213.
Move logic after merging cylc#2213.
Move logic after merging cylc#2213.
Move logic after merging cylc#2213.
Closes #2075
Adds a table recording task linearization to the suite database.