Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementing the new observable view #76

Closed
jjhesk opened this issue Jun 10, 2015 · 6 comments
Closed

implementing the new observable view #76

jjhesk opened this issue Jun 10, 2015 · 6 comments

Comments

@jjhesk
Copy link
Collaborator

jjhesk commented Jun 10, 2015

the library is coming from the ob . I am working on how to get this working on the existing lib. There are much work needed. I am trying to implement viewpager + header as slider + list view use ultimate recyclerview. I think this should be an add on to the current lib. This also solved the problem from #45

@cymcsg
Copy link
Owner

cymcsg commented Jun 11, 2015

I also think it's awesome to implement these features.

@jjhesk
Copy link
Collaborator Author

jjhesk commented Jun 12, 2015

@cymcsg will you do any updates in the next 12 hours? cause i am trying to pull

@cymcsg
Copy link
Owner

cymcsg commented Jun 12, 2015

Go ahead.Hoping for your enhancement.

@jjhesk jjhesk mentioned this issue Jun 13, 2015
Merged
@jjhesk
Copy link
Collaborator Author

jjhesk commented Jun 13, 2015

@cymcsg it is finally working now =)))) CHEERS!! it was a big hack!!

@cymcsg
Copy link
Owner

cymcsg commented Jun 14, 2015

That's awesome! I have merged it into dev.But do you think it is a better idea to enhance the demo of ScrollObservablesActivity or MainActivity? I can hardly see much of the new feature in the ScrollObservablesActivity.That's very kind of you.

@jjhesk
Copy link
Collaborator Author

jjhesk commented Jun 15, 2015

I have added and use viewpager on the bottom part. it takes extra mechanism to calculate the top moving part. I will come up with a better demo the next pull and because i am still working on the next pull. i will have another pull soon and this will not change any of your code. U can wait for me before you do any PR.. thank you.

@jjhesk jjhesk closed this as completed Jun 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants