Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect circularity when constructing an environment #77

Closed
moodymudskipper opened this issue Oct 28, 2022 · 2 comments · Fixed by #434
Closed

detect circularity when constructing an environment #77

moodymudskipper opened this issue Oct 28, 2022 · 2 comments · Fixed by #434
Milestone

Comments

@moodymudskipper
Copy link
Collaborator

moodymudskipper commented Oct 28, 2022

This will run forever, though it doesn't have to :

env <- new.env()
env$e <- env
construct(env)
We should keep a table of visited environments, and fall back to new.env() when we find circularity.
Maybe this should be done for first release since it's a bad look when nothing happens.

@moodymudskipper moodymudskipper added this to the 0.1 milestone Nov 4, 2022
@moodymudskipper moodymudskipper modified the milestones: 0.1, 0.2 Apr 2, 2023
@moodymudskipper
Copy link
Collaborator Author

moved since now default behavior doesn't trigger this

@moodymudskipper
Copy link
Collaborator Author

Rather than have {constructive} keep track of environments I think it would be better to have a function assess if the environment refers to itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant