Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Add ellipses to dm_disambiguate_cols(), dm_draw(), dm_examine_constraints(), dm_nycflights13() and dm_pixarfilms() #1035

Merged
merged 2 commits into from Jun 6, 2022

Conversation

krlmlr
Copy link
Collaborator

@krlmlr krlmlr commented Jun 6, 2022

for stable API.

@krlmlr krlmlr changed the title Add ellipses API: Add ellipses to dm_disambiguate_cols(), dm_draw(), dm_examine_constraints(), dm_nycflights13() and dm_pixarfilms() Jun 6, 2022
@krlmlr krlmlr merged commit 2902b11 into main Jun 6, 2022
@krlmlr krlmlr deleted the f-api-tweaks branch June 6, 2022 13:53
@krlmlr
Copy link
Collaborator Author

krlmlr commented Jun 6, 2022

Merging, because I'm basing another PR on this. A second pair of eyes would help nevertheless.

@TSchiefer
Copy link
Member

Looks good.
I could imagine that mainly the ellipses in dm_nycflights13() and dm_pixarfilms() could break some existing code. We should definitely mention it in NEWS.md

@krlmlr
Copy link
Collaborator Author

krlmlr commented Jun 7, 2022

Yeah, the PR title will go to the NEWS.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants