Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dm_paste() gives correct output for factor columns with many levels #1511

Merged
merged 5 commits into from Sep 20, 2022
Merged

fix: dm_paste() gives correct output for factor columns with many levels #1511

merged 5 commits into from Sep 20, 2022

Conversation

TSchiefer
Copy link
Member

closes #1510

@TSchiefer
Copy link
Member Author

could still add a test

krlmlr
krlmlr approved these changes Sep 12, 2022
View reviewed changes
Copy link
Collaborator

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a test would be great.

@github-actions github-actions bot mentioned this pull request Sep 12, 2022
Closed
@TSchiefer
Copy link
Member Author

test is in place.
Failing checks are unrelated.

This was referenced Sep 19, 2022
Closed
Closed
Closed
@krlmlr krlmlr changed the title avoid errors for factors with many levels fix: dm_paste() gives correct output for factor columns with many levels Sep 20, 2022
@krlmlr krlmlr merged commit 74e0714 into main Sep 20, 2022
@krlmlr krlmlr deleted the b-paste-many-leveled-factors branch September 20, 2022 02:35
@krlmlr
Copy link
Collaborator

krlmlr commented Sep 20, 2022

Thanks!

@krlmlr krlmlr mentioned this pull request Sep 23, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krlmlr krlmlr krlmlr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dm_paste(options = "tables") fails for factor col with too many levels
2 participants
@TSchiefer @krlmlr