Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Automation #28

Merged
merged 169 commits into from
Feb 22, 2022
Merged

WIP: Automation #28

merged 169 commits into from
Feb 22, 2022

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented May 5, 2020

Closes #27.

@pat-s
Copy link
Member

pat-s commented Jan 25, 2022

I used this branch today again for a CRAN release and it (still) worked great (with all changes from main).

I would be interested in putting work in to get this merged. What do you think @krlmlr?

@krlmlr
Copy link
Contributor Author

krlmlr commented Jan 25, 2022

Great it works for you. Same here.

Before merging, I think we want to:

  • replace devtools::submit_cran() with a home-grown solution
  • replace usethis::use_github_release() with a home-grown solution
  • ensure that existing tests pass
  • add new tests if possible
  • document the release process

Let's aim for a merge in late Q1.

@krlmlr krlmlr marked this pull request as ready for review February 17, 2022 20:06
@krlmlr krlmlr requested a review from pat-s February 17, 2022 20:07
@krlmlr
Copy link
Contributor Author

krlmlr commented Feb 17, 2022

Let's merge this into the main branch. There remain a few rough edges, I'll file issues.

@maelle: This adds pre_release(), release() and post_release() functions that automate the CRAN release process as much as possible. We always open a new branch cran-x.y.z and immediately update the main branch to version x.y.z.9000 -- this ensures that a CRAN release never blocks further development and that GitHub install will always give a 9xxx version. Curious to hear your thoughts.

Copy link
Member

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this huge PR and refining in small chunks sounds good to me.

Excited to see this getting merged!

@krlmlr krlmlr merged commit b5778e2 into main Feb 22, 2022
@krlmlr krlmlr deleted the f-27-automate branch February 22, 2022 10:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Automate CRAN release
2 participants