feat: Extract conventional commit messages for the changelog #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
reviewed
May 12, 2022
maelle
commented
May 12, 2022
maelle
commented
May 12, 2022
maelle
commented
May 12, 2022
maelle
commented
May 12, 2022
|
|
||
| Reviewed-by: Z | ||
| Refs: #123 | ||
| ## feat(lang) |
There was a problem hiding this comment.
we might want empty lines before and after h2?
|
I need to look at the failures |
|
@krlmlr now ready for review |
maelle
changed the title
krlmlr
approved these changes
May 12, 2022
There was a problem hiding this comment.
Thanks. Overall, I think it would have been sufficient to do something like
- docs: correct spelling
- chore!: drop support for Node 6
- BREAKING CHANGE: use JavaScript features not available in Node 6.
- ...for the highlighted part. Baby steps and such. We can flesh out details later.
|
|
||
| Reviewed-by: Z | ||
| Refs: #123 | ||
| ## feat(lang) |
Comment on lines
+20
to
+29
| ## docs | ||
| correct spelling of CHANGELOG | ||
|
|
||
| ## chore! | ||
| drop support for Node 6 | ||
|
|
||
| BREAKING CHANGE: use JavaScript features not available in Node 6. | ||
|
|
||
| ## feat(api)! | ||
| feat(api)!: send an email to the customer when a product is shipped |
There was a problem hiding this comment.
I would have expected those to look a bit like the following, but let's tackle this in a future PR:
Suggested change
| ## docs | |
| correct spelling of CHANGELOG | |
| ## chore! | |
| drop support for Node 6 | |
| BREAKING CHANGE: use JavaScript features not available in Node 6. | |
| ## feat(api)! | |
| feat(api)!: send an email to the customer when a product is shipped | |
| ## docs | |
| - correct spelling of CHANGELOG. | |
| ## chore | |
| - drop support for Node 6. | |
| ## Breaking change | |
| - use JavaScript features not available in Node 6. | |
| ## Breaking change | |
| ### api | |
| - send an email to the customer when a product is shipped | |
| ## feat | |
| ### api | |
| - send an email to the customer when a product is shipped |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.