Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve bump_version() (error) messages #328

Merged
merged 4 commits into from
May 18, 2022
Merged

feat: improve bump_version() (error) messages #328

merged 4 commits into from
May 18, 2022

Conversation

maelle
Copy link
Member

@maelle maelle commented May 17, 2022

when which is wrong and when there is no newsworthy change.

Fix #325
Fix #153

Better for users but also for us when trying things out. 😁

no_change_behavior <- arg_match(no_change_behavior)

check_clean(c("DESCRIPTION", news_path))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new line is more of a refactor: type 😅

@maelle maelle requested a review from krlmlr May 17, 2022 11:28
Copy link
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@maelle maelle merged commit 63f1b1b into main May 18, 2022
@maelle maelle deleted the bump-tweaks branch May 18, 2022 10:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix message in bump_version() Use rlang::arg_match() instead of check_which?
2 participants