Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix conventional commit regex #329

Merged
merged 1 commit into from
May 18, 2022
Merged

fix: Fix conventional commit regex #329

merged 1 commit into from
May 18, 2022

Conversation

maelle
Copy link
Member

@maelle maelle commented May 17, 2022

With the current regex, one could not run bump_version() on fledge's own commit log.

@maelle maelle requested a review from krlmlr May 17, 2022 12:18
krlmlr
krlmlr approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@maelle maelle merged commit 7585dc4 into main May 18, 2022
@maelle maelle deleted the regex-fix branch May 18, 2022 10:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krlmlr krlmlr krlmlr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maelle @krlmlr