Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: harvest PR title from merge commit messages #343

Merged
merged 21 commits into from
May 23, 2022
Merged

feat: harvest PR title from merge commit messages #343

merged 21 commits into from
May 23, 2022

Conversation

maelle
Copy link
Member

@maelle maelle commented May 20, 2022 •
edited

Fix #308

To replace #334

Still WIP

TODOS

  • Check there is a GitHub token. There is a similar check in auto.R
  • Add tests (with mocking)
  • Remove the demo edits of NEWS.md
  • See harvest PR title #334 (comment)
  • Regroup things into headers including "Uncategorized"

@krlmlr
Copy link
Contributor

krlmlr commented May 20, 2022 •
edited by maelle

  • Extract the PR number from the commit message
  • Use it as part of the NEWS entry (also with placeholder entry in offline mode)

maelle
maelle commented May 20, 2022
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
maelle
maelle commented May 20, 2022
View reviewed changes
R/update-news.R Outdated Show resolved Hide resolved
@maelle
Copy link
Member Author

maelle commented May 20, 2022

Need to build a tibble with

  • message
  • header %||% uncategorized
  • breaking or not

maelle
maelle commented May 20, 2022
View reviewed changes
R/update-news.R Show resolved Hide resolved
maelle
maelle commented May 23, 2022
View reviewed changes
DESCRIPTION Show resolved Hide resolved
maelle
maelle commented May 23, 2022
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
maelle
maelle commented May 23, 2022
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
maelle
maelle commented May 23, 2022
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
maelle
maelle commented May 23, 2022
View reviewed changes
R/update-news.R Outdated Show resolved Hide resolved
maelle
maelle commented May 23, 2022
View reviewed changes
R/update-news.R Outdated Show resolved Hide resolved
@maelle maelle changed the title harvest PR title feat: harvest PR title from merge commit messages May 23, 2022
maelle
maelle commented May 23, 2022
View reviewed changes
DESCRIPTION Outdated Show resolved Hide resolved
@maelle maelle marked this pull request as ready for review May 23, 2022 11:26
@maelle maelle requested a review from krlmlr May 23, 2022 11:46
krlmlr
krlmlr approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Can you please take another quick look, and merge?

R/update-news.R Show resolved Hide resolved
R/update-news.R Outdated Show resolved Hide resolved
tests/testthat/_snaps/demo/demo.md
@@ -315,6 +315,7 @@ cat(news, sep = "\n")
## # tea 0.0.0.9001
##
## - Add tests for cup of tea.
##
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find NEWS more concise if there is no empty line inbetween. Are there semantic differences?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#347

tests/testthat/setup.R Outdated Show resolved Hide resolved
@maelle @krlmlr
Update R/update-news.R
ce3a203 
Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
@maelle maelle mentioned this pull request May 23, 2022
Closed
@maelle maelle merged commit 7330f8e into main May 23, 2022
@maelle maelle deleted the pr-harvest branch May 23, 2022 12:47
@maelle maelle mentioned this pull request May 23, 2022
Merged
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krlmlr krlmlr krlmlr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get the NEWS item from the PR title
2 participants
@maelle @krlmlr