feat: harvest PR attribution from squash commits #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maelle
commented
May 23, 2022
krlmlr
approved these changes
May 24, 2022
| # A tibble: 2 x 4 | ||
| description type breaking scope | ||
| <chr> <chr> <lgl> <lgl> | ||
| 1 blop (@person) Uncategorized FALSE NA |
There was a problem hiding this comment.
At some point we can store this in a structured way. Not a show-stopper here.
Comment on lines
+147
to
+149
| author_lines <- description_lines[grepl(author_pattern(), description_lines)] | ||
| authors <- rematch2::re_match(author_lines, "<.*@users.noreply.github.com>")$.match | ||
| authors <- stats::na.omit(authors) |
There was a problem hiding this comment.
One re_match() call might be able to handle all of that, again, not a showstopper.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #344
Very related to #343 hence the priority bump 馃槄
TODOs