feat: capitalize first letter of each bullet #409
Conversation
maelle
changed the title
R/update-news.R
Outdated
| start_with_pkg <- (grepl(sprintf("^%s ", pkg_name), df$description) || | ||
| grepl(sprintf("^%s's", pkg_name), df$description)) |
There was a problem hiding this comment.
"^%s(?: |'s)" ? Extract regex to separate variable? And perhaps combine with regex above?
There was a problem hiding this comment.
In the end I realized the "code" regex was useless as toupper() will not touch those anyway.
R/update-news.R
Outdated
| news_item <- split(news_items, seq_len(nrow(news_items))) %>% | ||
| purrr::map(capitalize_description) | ||
| do.call(rbind, news_item) |
There was a problem hiding this comment.
I don't understand the need to split here.
map_dfr() ?
There was a problem hiding this comment.
map_dfr() requires dplyr which fledge does not depend upon hence the awkward split.
Should I define a helper map_dfr that would hide the split?
| df$description <- paste0( | ||
| toupper(substr(df$description, 1, 1)), | ||
| substr(df$description, 2, nchar(df$description)) | ||
| ) |
There was a problem hiding this comment.
Surprisingly tricky. I was thinking about a rematch2 solution, which could also include the grepl() logic from above, and allow for vectorization (and more compact code) perhaps?
"Bury the logic in one complex regex..." 🤔
There was a problem hiding this comment.
I'm re-reading ?toupper and actually one of the examples there is very similar to what I did above (which does not mean there are no better solutions!).
There was a problem hiding this comment.
One simple solution would be to add a dependency on https://cran.r-project.org/web/packages/snakecase/index.html but that might be overkill for one call only.
|
Are you still in favor of replacing this with rematch2 or is it fine as is? |
|
Thanks! No need to dive deeper here. |
Fix #360