Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post_release(): Issue with merging open pull request #525

Closed
pat-s opened this issue Sep 6, 2022 · 1 comment
Closed

post_release(): Issue with merging open pull request #525

pat-s opened this issue Sep 6, 2022 · 1 comment
Labels
auto 🚗 bug an unexpected problem or unintended behavior
Milestone

Comments

@pat-s
Copy link
Member

pat-s commented Sep 6, 2022

During a recent submission of {mlr3filters} the PR was not merged somehow and is still open as a DRAFT: mlr-org/mlr3filters#137

The branch was merged into main and pushed accordingly but it seems the "official" merge on GitHub and cleanup itself failed?

Haven't looked into the code yet but maybe an issue with the {usethis} helper (or possible API call) for merging PRs?

[ins] r$> fledge::post_release()
✔ Setting active project to '/Users/pjs/git/mlr-org/mlr3filters'Checking scope of `GITHUB_PAT` environment variable.Creating GitHub release.Opening release URL <https://github.com/mlr-org/mlr3filters/releases/tag/untagged-d93da5ba54f11c8f934e>.
VSCode WebView only supports showing local http content.
Opening in external browser...
Browsing https://github.com/mlr-org/mlr3filters/releases/tag/untagged-d93da5ba54f11c8f934eOpening release edit URL <https://github.com/mlr-org/mlr3filters/releases/edit/untagged-d93da5ba54f11c8f934e>.
VSCode WebView only supports showing local http content.
Opening in external browser...
Browsing https://github.com/mlr-org/mlr3filters/releases/edit/untagged-d93da5ba54f11c8f934eSwitching to branch main.Merging release branch.If this fails, resolve the conflict manually and push.
Already up to date, nothing to mergePushing main.
Trying to authenticate 'git' using ssh-agent...
[status] refs/heads/main: unchanged
[updated] 143fe1ad73..143fe1ad73 refs/remotes/origin/main
@maelle maelle added bug an unexpected problem or unintended behavior auto 🚗 labels Sep 9, 2022
@krlmlr
Copy link
Contributor

krlmlr commented Oct 19, 2022

Just seen this too. With me, this has happened when the main branch was updated externally, and not fetched or pulled locally.

We don't want to pull, but we want to fetch and, e.g., merge with origin/main .

@krlmlr krlmlr added this to the 0.1.1 milestone Oct 19, 2022
@krlmlr krlmlr closed this as completed in ac54b93 Feb 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto 🚗 bug an unexpected problem or unintended behavior
Development

No branches or pull requests

3 participants