-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Draft fledgeling object, ready for internal use #581
Conversation
@maelle: Can you please pick up from here? |
@krlmlr I added a bit more parsing, and tests, you can now review this. |
Working on writing should happen after both this and #584 are merged, but I'm working on paper in the meantime. I feel parsing the news a bit more should happen now too. |
why is the object immutable, more specifically, why not copy more of desc logic? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The h2 detection is broken, but we also don't need it here. Can you please remove it? Parsing the individual h1 sections would be done on demand, later.
Maybe I misunderstood h2. |
Can you share an example NEWS file where the h2 detection is triggered? |
The |
why would the header and content be stored together? |
Should the class name be |
I have code that also extracts the preamble: https://github.com/cynkra/fledge/tree/f-402-fledgeling-3 . |
but what about method names? |
why not add it to this branch? |
To avoid conflicts with your work. Pushing now. |
ok, sorry, I'm experimenting with Pandoc in no branch :-) |
Also keeping raw text now for preamble and all sections. We can do a perfect roundtrip with this object now, and should start using it everywhere in the codebase. |
Fixed corner case with empty preamble. Ready for review, talk soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be merged?
Closes #402.
TODOS