Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add test prefix to snapshot updates PR template #582

Merged
merged 4 commits into from
Jan 2, 2023
Merged

Conversation

maelle
Copy link
Member

@maelle maelle commented Nov 10, 2022

I'd like to also get rid of (null) but not sure where

@maelle maelle requested a review from krlmlr November 10, 2022 10:23
@krlmlr
Copy link
Contributor

krlmlr commented Nov 10, 2022

Thanks. I believe these PRs should never ever end up in NEWS.md . Do we have a prefix for that?

@maelle
Copy link
Member Author

maelle commented Nov 10, 2022

No but that would go in #339

@krlmlr
Copy link
Contributor

krlmlr commented Dec 21, 2022

GHA complains about the syntax -- should we use a separator different from : ?

@maelle
Copy link
Member Author

maelle commented Jan 2, 2023

GHA complains about the syntax -- should we use a separator different from : ?

Oops, it makes sense with YAML, sorry about that. I added quotes.

@krlmlr
Copy link
Contributor

krlmlr commented Jan 2, 2023

This now has conflicts too, sorry about that.

@krlmlr
Copy link
Contributor

krlmlr commented Jan 2, 2023

Unrelated, but why is the fledge workflow even run here?

@maelle
Copy link
Member Author

maelle commented Jan 2, 2023

I opened #597

Are further changes needed in this PR?

@krlmlr krlmlr merged commit c291370 into main Jan 2, 2023
@krlmlr krlmlr deleted the maelle-patch-1 branch January 2, 2023 10:24
@krlmlr
Copy link
Contributor

krlmlr commented Jan 2, 2023

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants