refactor: Use write_fledgling() to write NEWS.md
#588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
krlmlr
reviewed
Nov 28, 2022
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
maelle
commented
Jan 23, 2023
R/pandoc.R
Outdated
| } | ||
| if (length(versions) == 0) { | ||
| rlang::abort("Empty changelog") | ||
|
|
There was a problem hiding this comment.
decision to be made here between aborting and messaging 😅
Co-authored-by: maelle <maelle@users.noreply.github.com>
maelle
commented
Jan 30, 2023
R/commits.R
Outdated
| @@ -2,10 +2,6 @@ with_repo <- function(code) { | |||
| withr::with_dir(usethis::proj_get(), code) | |||
| } | |||
|
|
|||
| local_repo <- function(.local_envir = caller_env()) { | |||
There was a problem hiding this comment.
why has this been removed @krlmlr?
krlmlr
force-pushed
the
write-fledgeling
branch
from
7a2c139
to
47db1af
Compare
krlmlr
force-pushed
the
write-fledgeling
branch
from
8246e3f
to
d3d6db5
Compare
krlmlr
changed the title
write_fledgling() to write NEWS.md
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #147
Fix #586
Fix #336
TODOs
update_version().update_news()if notupdate_news(). I am not against keeping the name. I've thought ofrecord_changes().write_fledgling()to writeNEWS.md#588 (review) or keep it as a debt-labelled issue if we plan a debt-paying-back session soon? 😅 )