Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove false Markdown link? #592

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Remove false Markdown link? #592

merged 1 commit into from
Jan 2, 2023

Conversation

maelle
Copy link
Member

@maelle maelle commented Dec 1, 2022

Where is the styling bot name defined?

Where is the styling bot name defined?
@krlmlr
Copy link
Contributor

krlmlr commented Dec 21, 2022

Should we go with a regex, e.g., ignore users that match ^[0-9]+-github-actions ?

@maelle
Copy link
Member Author

maelle commented Jan 2, 2023

Do you mean we have no control over that username, is it defined by GitHub Actions? The problem with it is that it makes parsing wrong as it's not supposed to be a link.

@krlmlr
Copy link
Contributor

krlmlr commented Jan 2, 2023

I'm not sure where that username comes from, and I think we don't need to credit it in NEWS.md . Can we avoid mentioning it at all?

@maelle
Copy link
Member Author

maelle commented Jan 2, 2023

Before adding complexity to fledge I'd like to be sure where this username comes from. Where should I read more about the styling workflow?

@krlmlr krlmlr merged commit 0769b85 into main Jan 2, 2023
@krlmlr krlmlr deleted the maelle-patch-2 branch January 2, 2023 07:27
@krlmlr
Copy link
Contributor

krlmlr commented Jan 2, 2023

Thanks. Let's watch out for more instances of this problem to pinpoint the exact conditions when it occurs. This looks like a rabbit hole I'm not ready to enter today.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants