Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use the full power of {cli} #640

Merged
merged 2 commits into from
Mar 20, 2023
Merged

refactor: use the full power of {cli} #640

merged 2 commits into from
Mar 20, 2023

Conversation

maelle
Copy link
Member

@maelle maelle commented Feb 27, 2023

Fix #637

@maelle maelle requested a review from krlmlr February 27, 2023 14:17
@github-actions github-actions bot mentioned this pull request Feb 27, 2023
Closed
krlmlr
krlmlr reviewed Feb 27, 2023
View reviewed changes
Copy link
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Let's fix the tests first.

@maelle maelle requested a review from krlmlr March 20, 2023 08:40
@krlmlr krlmlr merged commit 8ae5296 into main Mar 20, 2023
@krlmlr krlmlr deleted the cli branch March 20, 2023 13:12
@krlmlr
Copy link
Contributor

krlmlr commented Mar 20, 2023

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krlmlr krlmlr Awaiting requested review from krlmlr

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use cli for error messages
2 participants
@maelle @krlmlr