Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add special CRAN release label to release PRs #649

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Conversation

maelle
Copy link
Member

@maelle maelle commented Mar 13, 2023

No description provided.

@maelle maelle requested a review from krlmlr March 13, 2023 09:25
@maelle maelle marked this pull request as ready for review March 13, 2023 09:25
cran_release_label <- label_names[grepl("^cran release", tolower(label_names))]
no_cran_release_label <- (length(cran_release_label) == 0)
if (no_cran_release_label) {
cran_release_label <- "CRAN release :station:"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚉 because this reminds me of a train ready for departure.

Copy link
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do we really need to PATCH the PR, or could we do it in one swoop?

@maelle
Copy link
Member Author

maelle commented Mar 14, 2023

Do we really need to PATCH the PR, or could we do it in one swoop?

We need it because you can't add a label to a PR while creating it. 😿

@krlmlr krlmlr merged commit dcf0d98 into main Mar 14, 2023
@krlmlr krlmlr deleted the cran-label branch March 14, 2023 09:01
@krlmlr
Copy link
Contributor

krlmlr commented Mar 14, 2023

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants