Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New internal release_after_cran_built_binaries() to support automated CRAN release from GHA #651

Merged
merged 18 commits into from
Mar 23, 2023

Conversation

maelle
Copy link
Member

@maelle maelle commented Mar 13, 2023

Fix #648

Is this where this code should live?

@maelle maelle marked this pull request as ready for review March 13, 2023 09:34
@maelle maelle requested a review from krlmlr March 13, 2023 09:35
@krlmlr
Copy link
Contributor

krlmlr commented Mar 13, 2023

Thanks. Here is good for now, I'll move it from here to fledge.yaml and distribute from there via actions-sync.

@krlmlr
Copy link
Contributor

krlmlr commented Mar 13, 2023

Thanks! I had to tweak a bit, will do a few more local tests.

@krlmlr
Copy link
Contributor

krlmlr commented Mar 16, 2023

https://github.com/cynkra/dm/actions/runs/4440862891

Works like a charm, thanks!

@krlmlr
Copy link
Contributor

krlmlr commented Mar 16, 2023

Due to the branch name, we're checking all dev versions with every push 🤪

@maelle
Copy link
Member Author

maelle commented Mar 20, 2023

Due to the branch name, we're checking all dev versions with every push 🤪

How so?

@krlmlr
Copy link
Contributor

krlmlr commented Mar 20, 2023

cran- prefix.

@maelle
Copy link
Member Author

maelle commented Mar 20, 2023

Oooh I am so sorry 🤦‍♀️

@krlmlr krlmlr changed the title feat: watch CRAN feat: New internal release_after_cran_built_binaries() to support automated CRAN release from GHA Mar 23, 2023
@krlmlr krlmlr merged commit 0cbd9a3 into main Mar 23, 2023
@krlmlr krlmlr deleted the cran-watching branch March 23, 2023 02:34
@krlmlr
Copy link
Contributor

krlmlr commented Mar 23, 2023

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

CRAN watching automation
2 participants